Repository navigation
i18n(ja) shorten About tab label so it fits the layout - #454
Merged
Merged
Conversation
The settings dialog shows 7 tabs in one row. The ja label for the About tab was 7 full width characters and overflowed. Use 情報 (info) instead. Refs hkdb#436
Owner
|
Thanks! |
Author
|
Thanks for merging both, @hkdb. The Japanese locale from #437 is in, and #454 shortened the About label so it fits the settings tab row.
My profile is github.com/theluckystrike, and there's a sponsors page at github.com/sponsors/theluckystrike too. Even a tiny one-time sponsorship would really mean something, since it says the time spent on Aerion landed well, and I'll gladly keep the ja strings current. It's fine if that's not your thing.
Michael
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #436 and #437. The ja label for the About tab in Settings was "バージョン情報" (7 full width characters), and it overflowed the 7 tab row. This changes it to "情報", which means "info". It matches the info icon and is as short as the zh labels. Only
settings.aboutin ja.json changes.