Skip to content

fix: open the tail container through the filter in LargeInventoryTests #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henrywang merged 1 commit into from
Oct 10, 2026
Merged

fix: open the tail container through the filter in LargeInventoryTests #190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions BerthlyUITests/LargeInventoryTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,22 +29,16 @@ final class LargeInventoryTests: XCTestCase {
XCTAssertTrue(app.staticTexts["containerDetailTitle"].waitForExistence(timeout: 5))
app.typeKey(.escape, modifierFlags: [])
XCTAssertTrue(app.staticTexts["containerDetailTitle"].waitForNonExistence(timeout: 5))
let computeList = app.descendants(matching: .any)["computeList"]
XCTAssertTrue(computeList.waitForExistence(timeout: 5))
let computeOutline = computeList.descendants(matching: .outline).firstMatch
XCTAssertTrue(computeOutline.waitForExistence(timeout: 5))
for _ in 0..<3 {
computeOutline.scroll(byDeltaX: 0, deltaY: -10_000)
}
// container-099 is the last *container* row, seven stopped-machine rows above the actual
// bottom edge — landing a scroll-to-max click there avoids the boundary row (machine-018,
// dead last in the list), where the same click reproducibly raced a stale/degenerate frame.
// Reached through the filter, not by scrolling (#182): XCUITest's synthetic scroll on this
// 100+ row list doesn't settle. Measured locally: three -10_000 scrolls sometimes stopped
// short of the bottom, and after reaching it the list sometimes drifted ~1900pt back up
// within 2.5s, leaving the row offscreen right after it tested hittable.
setComputeFilter("container-099", in: app)
let tailContainer = app.staticTexts["computeRow-container-099"]
let tailIsHittable = NSPredicate(format: "hittable == true")
expectation(for: tailIsHittable, evaluatedWith: tailContainer)
waitForExpectations(timeout: 5)
XCTAssertTrue(tailContainer.waitForExistence(timeout: 5))
tailContainer.click()
assertTitle(app.staticTexts["containerDetailTitle"], equals: "container-099")
clearComputeFilter(in: app)

setComputeFilter("container-000", in: app)
XCTAssertTrue(firstContainer.waitForExistence(timeout: 5))
Expand Down