Repository navigation
fix: open the tail container through the filter in LargeInventoryTests - #190
Merged
Merged
Conversation
XCUITest's synthetic scroll on the 100+ row compute list doesn't settle: it sometimes stops short of the bottom, and after reaching it the list can drift ~1900pt back up within 2.5s, so the row went offscreen between the hittable check and the click. The filter brings the row into view with no scroll to race.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #182
Cause
testLargeInventorySupportsNavigationAndLifecycleWorkflowsscrolled the 100+ row compute list with threescroll(byDeltaX: 0, deltaY: -10_000)calls, waited forcomputeRow-container-099to be hittable, then clicked it. XCUITest's synthetic scroll on that list doesn't settle. Measured locally:{{0, 768}, {0, 0}}CI signature ({{0, 1107}, …}locally).The click came 0.3s after the hittable check, so it raced that drift.
Ruled out along the way:
MockContainerServicehas no refresh timer.Fix
Open
container-099through the existing compute filter, as the test already does formachine-018. There is no scroll left to race. A comment in the test records the measurements so the scroll isn't reintroduced.Coverage change: the test no longer exercises scrolling a long list. That was the unreliable part, and the filter is how a user reaches a deep row in a 100+ item list.
Verification
-test-iterations 15 -run-tests-until-failure). Before the fix it failed on the 1st or 2nd run on the same machine. The otherLargeInventoryTeststest also passed 15/15.swiftlint lint --strictclean.🤖 Generated with Claude Code