mbo/hash: measurements --config pass-through + bump hermetic LLVM/clang to 22.1.8 - #247
Merged
Conversation
…olchain run_measurements.py / hash_benchmark_report.py 'run' gain --config, forwarded to the perf `bazel run` (e.g. --config clang for the hermetic LLVM toolchain; omit for native gcc). So you can measure a machine under each compiler and the recorded compiler + bundle filename match the toolchain used.
Flip `llvm_version` 20.1.8 -> 22.1.8 (the 22.1.8 distributions were already registered). This is the toolchain `--config=clang` uses; validated locally that the hash benchmark builds under it. CI's clang matrix (and macos-26 ASAN) is the broad validation.
helly25
changed the title
helly25
enabled auto-merge (squash)
July 11, 2026 11:12
Fab-Cat
approved these changes
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toolchain prep so the authoritative benchmark runs can pick a compiler cleanly. Both together, since we want to measure under each toolchain.
--configpass-through.run_measurements.py/hash_benchmark_report.py rungain--config, forwarded to the perfbazel run(e.g.--config clang; omit for native gcc). So a machine can be measured under each compiler and the recorded compiler + bundle filename (from #246) match the toolchain used.LLVM pin 20.1.8 → 22.1.8. The hermetic clang toolchain
--config=clangresolves to; the 22.1.8 distributions were already registered. Validated locally:bazel build --config=clang -c opt //mbo/hash:hash_benchmarkbuilds and reportsclang-22.Watch on CI:
absolute_pathsis not set - per prior notes LLVM 22 on macos-26 ASAN wanted it to avoid a compiler-rtFindDynamicShadowStarthang; if that job hangs, the fix isabsolute_paths = Trueon thellvm.toolchain(...)call.