Conversation
Flip `llvm_version` 20.1.8 -> 22.1.8 (the 22.1.8 distributions were already registered). This is the toolchain `--config=clang` uses; validated locally that the hash benchmark builds under it. CI's clang matrix (and macos-26 ASAN) is the broad validation.
Owner
Author
|
Folded into #247 (doing both together so the benchmark runs can pick the toolchain cleanly). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flips the pinned hermetic LLVM/clang toolchain (
--config=clang) from 20.1.8 → 22.1.8 (the 22.1.8 distributions were already registered as a forward-looking matrix rung). This is the toolchain the measurement--config clang(#247) records, and the newer clang for the CI matrix.Validated locally:
bazel build --config=clang -c opt //mbo/hash:hash_benchmarksucceeds on 22.1.8 (reportsclang-22).Watch in CI:
absolute_pathsis not set on the toolchain. Per prior notes, LLVM 22 on macos-26 ASAN wantedabsolute_pathsto avoid a compiler-rtFindDynamicShadowStarthang - if the macos-26 ASAN job hangs/fails, the fix isabsolute_paths = Trueon thellvm.toolchain(...)call. CI's clang matrix + ASAN is the real validation here.