mbo/hash/measurements: tag build compiler into bundle name + provenance; drop placeholder bundle - #246
Merged
Merged
Conversation
…me; drop placeholder bundle The benchmark binary now records its own build compiler via google/benchmark custom context (`compiler` = clang-NN / gcc-NN, plus `compiler_version`), since GCC and Clang perf differs and is a first-class axis of a measurement. The system `cc` capture is dropped (it need not be what bazel built with). The per-machine bundle filename gains the compiler: `<slug>_<cores>c_<compiler>_<gitsha8>_<stamp>.tgz`, so clang and gcc builds on the same machine stay distinct. Also drops the placeholder M5 Pro bundle (old 18-size #243 data) - it is replaced by the authoritative M5/Zen5 runs, and removing it clears the stale "expected but never pushed" LFS reference left by the squash-merge.
helly25
enabled auto-merge (squash)
July 11, 2026 09:54
Fab-Cat
approved these changes
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prep before the authoritative M5/Zen5 runs.
Compiler as a first-class measurement axis. We build with both GCC and Clang, and their perf differs, so:
compiler(clang-NN/gcc-NN) +compiler_version. The systemcccapture in_machine_augmentis dropped (it need not be what bazel built with).<slug>_<cores>c_<compiler>_<gitsha8>_<stamp>.tgz, so clang and gcc builds on one machine are distinct data with distinct names. Verified: a fast run here taggedclang-21.Drops the placeholder M5 bundle (old 18-size #243 data) - it is replaced by the authoritative runs anyway, and removing it clears the stale "expected but never pushed" LFS reference the squash-merge left behind. (Charts stay as the current published figures until the authoritative runs refresh them.)