Skip to content

provider-actions: generalize AWS-specific patterns and align test protocol - #80

Open
AdamTylerLynch wants to merge 1 commit into
hashicorp:mainfrom
AdamTylerLynch:fix/provider-actions-generic
Open

provider-actions: generalize AWS-specific patterns and align test protocol#80
AdamTylerLynch wants to merge 1 commit into
hashicorp:mainfrom
AdamTylerLynch:fix/provider-actions-generic

Conversation

@AdamTylerLynch

@AdamTylerLynch AdamTylerLynch commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Surgical fixes to the provider-actions skill, including three factual errors:

  1. Inverted type guidance. The skill instructed using fwtypes.String over
    types.String — but fwtypes is terraform-provider-aws's internal type
    package. Outside that repo the guidance is exactly backwards. Now recommends
    terraform-plugin-framework/types, noting repo-specific type layers as a
    convention to follow when present
  2. Non-existent polling API. The wait.WaitForStatus/wait.Options example is
    not a public library. Replaced with a working ticker + context-deadline polling
    loop that reports progress via resp.SendProgress, with retry.StateChangeConf
    noted as the alternative
  3. Inconsistent progress API. The Invoke example used resp.Progress.Set(ctx, …)
    while the requirements section documented resp.SendProgress(…). Standardized on
    SendProgress

Also: client from Configure (a.client) instead of AWS's a.Meta().Client(ctx);
test example aligned to ProtoV6ProviderFactories (consistent with
provider-test-patterns); progress events throttled to 30s while polling at 5s
(matching the interval the old example used); the sweeper code block replaced with a
delegation to provider-test-patterns, which owns the sweeper pattern;
regexp.MustCompile instead of AWS's regexache; .changelog/ and terrafmt
marked as provider-specific conventions to check in the target repo; version-bound
statements phrased "as of Terraform 1.14" so the skill ages gracefully.

Verification: scripts/validate-structure.sh passes; single-file diff.


Fixes #40 — the inverted fwtypes guidance reported there is finding 1 above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

provider actions - fwtypes.StringType

1 participant