provider-actions: generalize AWS-specific patterns and align test protocol - #80
Open
AdamTylerLynch wants to merge 1 commit into
Open
provider-actions: generalize AWS-specific patterns and align test protocol#80AdamTylerLynch wants to merge 1 commit into
AdamTylerLynch wants to merge 1 commit into
Conversation
This was referenced Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surgical fixes to the
provider-actionsskill, including three factual errors:fwtypes.Stringovertypes.String— butfwtypesisterraform-provider-aws's internal typepackage. Outside that repo the guidance is exactly backwards. Now recommends
terraform-plugin-framework/types, noting repo-specific type layers as aconvention to follow when present
wait.WaitForStatus/wait.Optionsexample isnot a public library. Replaced with a working ticker + context-deadline polling
loop that reports progress via
resp.SendProgress, withretry.StateChangeConfnoted as the alternative
resp.Progress.Set(ctx, …)while the requirements section documented
resp.SendProgress(…). Standardized onSendProgressAlso: client from
Configure(a.client) instead of AWS'sa.Meta().Client(ctx);test example aligned to
ProtoV6ProviderFactories(consistent withprovider-test-patterns); progress events throttled to 30s while polling at 5s(matching the interval the old example used); the sweeper code block replaced with a
delegation to
provider-test-patterns, which owns the sweeper pattern;regexp.MustCompileinstead of AWS'sregexache;.changelog/andterrafmtmarked as provider-specific conventions to check in the target repo; version-bound
statements phrased "as of Terraform 1.14" so the skill ages gracefully.
Verification:
scripts/validate-structure.shpasses; single-file diff.Fixes #40 — the inverted
fwtypesguidance reported there is finding 1 above.