Add missing Android signing cert to passkey origin allowlist and assetlinks.json#362
Conversation
Google re-signs Play Store-distributed APKs with its own Play App Signing key, which differs from the upload keystore already listed here. Passkey registration and login were failing for Play Store-installed users because their Credential Manager origin (android:apk-key-hash: derived from the Play Signing cert) never matched any entry in this allowlist. Assisted-by: Claude Code:claude-sonnet-5
pub.hackers.android is also distributed via GitHub Releases/F-Droid, built directly from the upload keystore rather than re-signed by Google Play. That certificate's fingerprint was missing from assetlinks.json, so those installs failed Android's Digital Asset Links check before a passkey request ever reached the server. Assisted-by: Claude Code:claude-sonnet-5
|
Warning Review limit reached
Next review available in: 42 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAndroid Digital Asset Links now include an additional certificate fingerprint, and passkey configuration comments clarify Play App Signing versus upload/release keystores. The platform-specific passkey origin preference test was removed. ChangesAndroid signing associations
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request adds the Google Play App Signing key fingerprint and origin for the Android app to the asset links and passkey configurations across both the legacy and new stacks. The reviewer noted that the development package configuration is missing from the new stack's asset links (web-next/public/.well-known/assetlinks.json) and suggested adding it to match the legacy configuration and facilitate local debugging.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| "AD:C6:2C:B4:7B:C0:7D:26:48:D5:C8:E5:51:88:BF:1E:82:33:B4:CC:5A:A3:74:49:25:D0:C4:3C:32:D7:12:BB", | ||
| "52:A0:14:21:02:CD:30:FD:8B:29:A3:ED:80:2B:0A:BE:AF:AB:37:29:79:39:84:1A:B7:9E:39:05:AF:64:D5:1A" | ||
| ] | ||
| } | ||
| } |
There was a problem hiding this comment.
The pub.hackers.android.dev package is present in graphql/static/.well-known/assetlinks.json but is missing from web-next/public/.well-known/assetlinks.json. To ensure that developers can test and debug the Android application against the new stack (web-next/), we should include the dev package and its debug certificate fingerprint here as well.
"AD:C6:2C:B4:7B:C0:7D:26:48:D5:C8:E5:51:88:BF:1E:82:33:B4:CC:5A:A3:74:49:25:D0:C4:3C:32:D7:12:BB",
"52:A0:14:21:02:CD:30:FD:8B:29:A3:ED:80:2B:0A:BE:AF:AB:37:29:79:39:84:1A:B7:9E:39:05:AF:64:D5:1A"
]
}
},
{
"relation": [
"delegate_permission/common.handle_all_urls",
"delegate_permission/common.get_login_creds"
],
"target": {
"namespace": "android_app",
"package_name": "pub.hackers.android.dev",
"sha256_cert_fingerprints": [
"CA:A4:96:E9:46:6C:68:29:7F:74:00:D6:33:45:F7:0B:F9:DD:81:B9:49:53:8B:94:32:B8:D0:60:B2:31:10:5B"
]
}
}5110b35 to
00ae7c6
Compare
00ae7c6 to
ba342a4
Compare
Problem
Passkey registration/login fails on Android, depending on which build a user has installed.
pub.hackers.androidis distributed through two different channels with two different signing certificates:.github/workflows/fdroid-release.ymlinhackers-pub/android) — signed directly withhackerspub-release.jks, the developer's own upload key.Android's Credential Manager embeds the caller's cert hash into the WebAuthn origin as
android:apk-key-hash:<base64url(SHA-256(signing cert))>, and the OS only returns this origin at all if the cert also appears insha256_cert_fingerprintsin/.well-known/assetlinks.jsonfor the calling package. Bothmodels/passkey.ts'sPLATFORM_ORIGINS.androidallowlist andassetlinks.jsononly listed one of the two certs (and not even the same one), so one distribution channel was always broken:assetlinks.jsonlisted only the Play Signing cert (AD:C6:2C:B4...).models/passkey.tslisted only the upload-key cert (52:A0:14:21...→UqAUIQLNMP2LKaPtgCsKvq...), fromhackerspub-release.jks.So Play Store installs failed WebAuthn origin verification server-side, and F-Droid/GitHub-Release installs failed the OS-level Digital Asset Links check before even reaching the server.
Fix
Add the missing fingerprint to both sides so each distribution channel's actual signing cert is present in both files:
models/passkey.ts: addandroid:apk-key-hash:rcYstHvAfSZI1cjlUYi_HoIztMxao3RJJdDEPDLXErs(Play Signing key) alongside the existing upload-key hash.graphql/static/.well-known/assetlinks.jsonandweb-next/public/.well-known/assetlinks.json: add52:A0:14:21:...:64:D5:1A(upload key) alongside the existing Play Signing fingerprint.Debug builds (
pub.hackers.android.dev) were already correctly configured and are unchanged.A companion PR keeps
hackers-pub/android'sdocs/assetlinks.jsonreference copy in sync.Verification
Fully reproducible, no external assumptions:
Also verified
@simplewebauthn/server@13.1.1'sverifyRegistrationResponse.js/verifyAuthenticationResponse.js(resolved in this repo'snode_modules) does a plainexpectedOrigin.includes(origin)string-equality check — no special parsing ofandroid:origins — so both entries need to be byte-exact, which they now are.Test plan
hackerspub-12.apk), register a passkey, sign out, sign back in via passkey.hackerspub-release.jks(e.g. from a GitHub Release), repeat the same passkey register/login flow.AI Disclosure
Investigated and drafted with Claude Code (
claude-sonnet-5).hackerspub,hackerspub-android,hackerspub-ios, andhackerspub-android-prod; decompiling the resolvedandroidx.credentials:credentials:1.6.0dependency; runningapksigner/keytoolagainst a real downloaded Play Store APK and the actual release keystore.