Add upload keystore fingerprint to assetlinks.json reference copy#165
Conversation
Keep this in sync with the served copies in hackers-pub/hackerspub: pub.hackers.android is also distributed via GitHub Releases/F-Droid, built directly from hackerspub-release.jks rather than re-signed by Google Play, and that certificate's fingerprint was missing. Assisted-by: Claude Code:claude-sonnet-5
|
Warning Review limit reached
Next review available in: 59 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
docs/assetlinks.jsonhere is a reference copy of the Digital Asset Links file served fromhackers-pub/hackerspub. It only listed the Google Play App Signing certificate fingerprint forpub.hackers.android, missing the fingerprint ofhackerspub-release.jks— the keystore this repo's own.github/workflows/fdroid-release.ymluses to sign APKs distributed via GitHub Releases/F-Droid. Those installs fail Android's Digital Asset Links check (needed for passkey support) because their signing cert isn't listed.Companion PR on the backend: hackers-pub/hackerspub#362, which fixes the same gap in the actually-served
assetlinks.jsonfiles and adds the corresponding entry tomodels/passkey.ts's WebAuthn origin allowlist.Fix
Add
52:A0:14:21:...:64:D5:1A(thehackerspub-release.jksfingerprint, confirmed viakeytool -list -v -keystore hackerspub-release.jks -alias hackerspub) alongside the existing Play Signing fingerprint.AI Disclosure
Investigated and drafted with Claude Code (
claude-sonnet-5); see hackers-pub/hackerspub#362 for the full investigation. Change here is a one-line JSON addition to keep this reference copy in sync; verified against the actualhackerspub-release.jksfile in this repo.