Repository navigation
php: Adopt .tool-versions and standardise setup scripts - #171
Merged
Merged
Conversation
script/setup used brew and was interactive and macOS-only, alongside a separate Windows PowerShell script. script/setup now bootstraps composer locally as composer.phar, using the official installer and verifying the signature against composer.github.io, then installs dependencies. script/test and script/start use that local composer.phar. Drops setup.ps1 and updates the README. mise builds php from source, which needs system libraries the GitHub runner does not ship. script/system-packages installs them. It runs before the toolchain is built, so it cannot live in script/setup. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
emdash-ie
approved these changes
Oct 9, 2026
emdash-ie
left a comment
emdash-ie
left a comment
There was a problem hiding this comment.
This looks fine! I haven’t run the system-packages script locally, but it looks reasonable. I have installed PHP from my package manager and used the setup, start, and test scripts.
|
I can also see the CI install and test worked fine: https://github.com/guardian/coding-exercise-project/actions/runs/37916646747/job/113774382531 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
script/setup used brew and was interactive and macOS-only, alongside a separate Windows PowerShell script.
script/setup now bootstraps composer locally as composer.phar, using the official installer and verifying the signature against composer.github.io, then installs dependencies. script/test and script/start use that local composer.phar. Drops setup.ps1 and updates the README.
mise builds php from source, which needs system libraries the GitHub runner does not ship. script/system-packages installs them. It runs before the toolchain is built, so it cannot live in script/setup.
Base
fix/php(#170), so the diff shows only this branch's changes. Merge #170 first.Part of #143.