Repository navigation
php: Fix skeleton test to pass and expose testable code - #170
Merged
Merged
Conversation
Tests.php asserted assertSame(true, false), which always fails. code.php echoed output and returned nothing, so there was nothing to assert on. It now exposes a greeting() function and guards the direct invocation so the file can be required without side effects. The test asserts on the return value. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests.php asserted assertSame(true, false), which always fails.
code.php echoed output and returned nothing, so there was nothing to assert on. It now exposes a greeting() function and guards the direct invocation so the file can be required without side effects. The test asserts on the return value.
Base
platform/tool-versions-ci(#144), so the diff shows only this branch's changes. Merge #144 first.Part of #143.