Kingamadej 80 takeoff detection - #81
Open
cyber-kinga wants to merge 5 commits into
Open
Conversation
Bartosz-Slowik
requested changes
Aug 11, 2023
Bartosz-Slowik
left a comment
Bartosz-Slowik
left a comment
Collaborator
There was a problem hiding this comment.
I have a few issues.
- this will trigger if at ANY point during the installation into the rocket the cansat is tilted/rotated.
- this should be in a separate function.
- I think match would be better than this if/else
This reverts commit 03ec3d7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote some code that aims to detect takeoff. The idea is to detect when acceleration vector changes - when it goes upwards.