tctl acl update/create: support output terraform (dry-run) - #69347
Open
kimlisa wants to merge 2 commits into
Open
tctl acl update/create: support output terraform (dry-run)#69347kimlisa wants to merge 2 commits into
kimlisa wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: acaac3fa7e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
kimlisa
force-pushed
the
lisa/tctl-acl-terra
branch
from
August 5, 2026 07:45
acaac3f to
f15bc0b
Compare
kopiczko
approved these changes
Aug 5, 2026
2 tasks
kimlisa
force-pushed
the
lisa/move-acl-terraform
branch
from
August 12, 2026 19:42
96299f2 to
4665273
Compare
kimlisa
force-pushed
the
lisa/tctl-acl-terra
branch
from
August 13, 2026 05:53
f7ba320 to
80a8683
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of https://github.com/gravitational/teleport.e/issues/8271
This PR supports
tctl acl create/update --output=terraformcommand to print terraform configs without applying the changes (dry-run)Integration test is located in enterprise: https://github.com/gravitational/teleport.e/pull/9363 (it includes example output of the command through golden files)
Changelog:
tctl acl createandtctl acl updatenow support--output=terraformto print the Terraform config for the resulting resources instead of applying the change (dry-run).Manual Test Plan
Test Environment
cloud staging
Test Cases
both cases tests for a custom and a preset list:
tctl acl create --output=terraform ...prints terraform config, and does not create the resourcestctl acl update ABCD --output=terraform ...prints terraform config, and does not update the resource