Skip to content

tctl acl update/create: support output terraform (dry-run) - #69347

Open
kimlisa wants to merge 2 commits into
lisa/move-acl-terraformfrom
lisa/tctl-acl-terra
Open

tctl acl update/create: support output terraform (dry-run)#69347
kimlisa wants to merge 2 commits into
lisa/move-acl-terraformfrom
lisa/tctl-acl-terra

Conversation

@kimlisa

@kimlisa kimlisa commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

part of https://github.com/gravitational/teleport.e/issues/8271

This PR supports tctl acl create/update --output=terraform command to print terraform configs without applying the changes (dry-run)

Integration test is located in enterprise: https://github.com/gravitational/teleport.e/pull/9363 (it includes example output of the command through golden files)

Changelog: tctl acl create and tctl acl update now support --output=terraform to print the Terraform config for the resulting resources instead of applying the change (dry-run).

Manual Test Plan

Test Environment

cloud staging

Test Cases

both cases tests for a custom and a preset list:

  • tctl acl create --output=terraform ... prints terraform config, and does not create the resources
  • tctl acl update ABCD --output=terraform ... prints terraform config, and does not update the resource

@github-actions github-actions Bot added size/md tctl tctl - Teleport admin tool labels Aug 5, 2026
@github-actions
github-actions Bot requested review from avatus and kopiczko August 5, 2026 07:29

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: acaac3fa7e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread tool/tctl/common/accesslist/update.go
@kimlisa
kimlisa force-pushed the lisa/tctl-acl-terra branch from acaac3f to f15bc0b Compare August 5, 2026 07:45
@r0mant
r0mant requested review from smallinsky and removed request for avatus August 6, 2026 16:05
@kimlisa
kimlisa force-pushed the lisa/move-acl-terraform branch from 96299f2 to 4665273 Compare August 12, 2026 19:42
@kimlisa
kimlisa force-pushed the lisa/tctl-acl-terra branch from f7ba320 to 80a8683 Compare August 13, 2026 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/md tctl tctl - Teleport admin tool

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants