docs: add tctl and Terraform methods for creating Access Lists - #69407
docs: add tctl and Terraform methods for creating Access Lists#69407kimlisa wants to merge 1 commit into
Conversation
|
Amplify deployment status
Preview links for changed docs pages
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bb73863f81
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
bb73863 to
a0f51ee
Compare
| @@ -0,0 +1,2 @@ | |||
| `tctl acl create` was introduced in `tctl` v18.10.3. On earlier versions of | |||
| `tctl`, use the Web UI. | |||
There was a problem hiding this comment.
In the JIT and Standing guides: the Terraform tab points to a Web UI step that no longer exists in the docs. In both jit-access-list.mdx and standing-access-list.mdx, the new Terraform tab says:
"On earlier versions of
tctl, use the Web UI instead: the guided flow mirrors your input as a Terraform module, which you can copy at the final Deployment step."
But the Web UI tab in this same diff was rewritten to drop the old "Deploy the Access List" section entirely; it now just says "click Create Access List Now." There's no more mention of a Terraform-copy option at the Deployment step anywhere in the Web UI tab. So a reader on an old tctl version who follows that fallback instruction won't find what they're told to look for.
Either the Web UI Deployment step still has a "copy Terraform" option and that needs to stay documented in the webui tab, or it doesn't and this fallback sentence is stale and needs rewriting. I have Version: 18.10.3 nd am not sure how to roll my own cluster back to an earlier version to test it out.
part of https://github.com/gravitational/teleport.e/issues/8271
Updates the doc on access list. The custom, jit, and standing access list creating guides now also adds guides to create list through tctl and terraform.
🛑 TODO: