Skip to content

chore(internal/config): remove excluded_dependencies field from JavaModule config struct #6675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhumin8 merged 1 commit into from
Jul 8, 2026
Merged

chore(internal/config): remove excluded_dependencies field from JavaModule config struct #6675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion doc/config-schema.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,6 @@ This document describes the schema for the librarian.yaml.
| `artifact_id` | string | Is the Maven artifact ID. |
| `client_documentation_override` | string | Allows the "client_documentation" field in .repo-metadata.json to be overridden. |
| `codeowner_team` | string | Is the GitHub team that owns the code. |
| `excluded_dependencies` | string | Is a list of dependencies to exclude. |
| `excluded_poms` | list of string | Is a list of artifact ids, whose module should be excluded when updating pom.xml and are omitted when counting new modules. |
| `extra_versioned_modules` | string | Is a list of extra versioned modules. |
| `group_id` | string | Is the Maven group ID, defaults to "com.google.cloud". |
Expand Down
3 changes: 0 additions & 3 deletions internal/config/language.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,9 +500,6 @@ type JavaModule struct {
// CodeownerTeam is the GitHub team that owns the code.
CodeownerTeam string `yaml:"codeowner_team,omitempty"`

// ExcludedDependencies is a list of dependencies to exclude.
ExcludedDependencies string `yaml:"excluded_dependencies,omitempty"`

// ExcludedPOMs is a list of artifact ids, whose module should be excluded
// when updating pom.xml and are omitted when counting new modules.
ExcludedPOMs []string `yaml:"excluded_poms,omitempty"`
Expand Down
3 changes: 0 additions & 3 deletions internal/librarian/library.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,9 +611,6 @@ func mergeJava(dst, src *config.JavaModule) *config.JavaModule {
if src.CodeownerTeam != "" {
res.CodeownerTeam = src.CodeownerTeam
}
if src.ExcludedDependencies != "" {
res.ExcludedDependencies = src.ExcludedDependencies
}
if src.ExcludedPOMs != nil {
res.ExcludedPOMs = src.ExcludedPOMs
}
Expand Down
2 changes: 0 additions & 2 deletions internal/librarian/library_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1468,7 +1468,6 @@ func TestMergeJava(t *testing.T) {
ArtifactID: "new-artifact",
ClientDocumentationOverride: "doc",
CodeownerTeam: "team",
ExcludedDependencies: "ex-dep",
ExcludedPOMs: []string{"ex-pom"},
ExtraVersionedModules: "extra",
GroupID: "com.new",
Expand All @@ -1493,7 +1492,6 @@ func TestMergeJava(t *testing.T) {
ArtifactID: "new-artifact",
ClientDocumentationOverride: "doc",
CodeownerTeam: "team",
ExcludedDependencies: "ex-dep",
ExcludedPOMs: []string{"ex-pom"},
ExtraVersionedModules: "extra",
GroupID: "com.new",
Expand Down
Loading