chore(internal/config): remove excluded_dependencies field from JavaModule config struct - #6675
Merged
Merged
Conversation
…odule config struct
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the unused excluded_dependencies field from the Java configuration schema, the JavaModule struct, the merge logic in library.go, and the associated unit tests. As there are no review comments, I have no feedback to provide.
sofisl
approved these changes
Jul 7, 2026
zhumin8
marked this pull request as ready for review
July 8, 2026 14:15
sofisl
pushed a commit
to sofisl/librarian
that referenced
this pull request
Jul 8, 2026
…odule config struct (googleapis#6675) The `excluded_dependencies` field in `JavaModule` is no longer needed and is being removed. Note: wait googleapis/google-cloud-java#13676 that removes these from google-cloud-java/librarian.yaml successfully merge in Fixes googleapis#5901
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
excluded_dependenciesfield inJavaModuleis no longer needed and is being removed.Note: wait googleapis/google-cloud-java#13676 that removes these from google-cloud-java/librarian.yaml successfully merge in
Fixes #5901