Skip to content

fix(bigquery): [WIP] add gc.collect before socket leak test to reduce flakiness #17949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chalmerlowe wants to merge 1 commit into from
Closed

fix(bigquery): [WIP] add gc.collect before socket leak test to reduce flakiness #17949

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/google-cloud-bigquery/tests/system/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2182,6 +2182,11 @@ def test_dbapi_dry_run_query(self):

def test_dbapi_connection_does_not_leak_sockets(self):
pytest.importorskip("google.cloud.bigquery_storage")

# Ensure any garbage collection from previous tests is done to avoid false positives.
import gc
gc.collect()

current_process = psutil.Process()
conn_start = current_process.net_connections()
conn_count_start = len(conn_start)
Expand Down
Loading