fix(bigquery): [WIP] add gc.collect before socket leak test to reduce flakiness - #17949
Closed
chalmerlowe wants to merge 1 commit into
Closed
fix(bigquery): [WIP] add gc.collect before socket leak test to reduce flakiness#17949chalmerlowe wants to merge 1 commit into
chalmerlowe wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a garbage collection call (gc.collect()) at the start of the test_dbapi_connection_does_not_leak_sockets test to clean up resources from previous tests and prevent false positives during socket leak detection. There are no review comments, and I have no additional feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The system test
test_dbapi_connection_does_not_leak_socketscan be flaky, failing with assertions that more sockets are open at the end than at the start. This is often caused by non-deterministic garbage collection of sockets from previous tests running in the same process, which are finally collected during the test execution, or background noise that wasn't cleaned up before the test started.Solution
Added
gc.collect()explicitly at the very beginning oftest_dbapi_connection_does_not_leak_sockets, before taking the initial socket count (conn_start). This ensures a cleaner baseline and reduces false positives caused by delayed cleanup from other tests.Notes to Reviewers
This is a standard pattern for stabilizing process-wide socket count assertions in noisy test environments (like parallel execution with
pytest-xdist). It complements the previous fixes that ensured explicit closure of channels and releasing of references.