Skip to content

test: quote and clean up temporary flagfile paths #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shubham-Padkonde wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test: quote and clean up temporary flagfile paths #79

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions ml_collections/config_flags/tests/config_overriding_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
"""Tests for ml_collection.config_flags."""

import copy
import os
import shlex
import sys
import tempfile
Expand Down Expand Up @@ -965,11 +966,12 @@ def testFlagfile(self):
config.foo = 3
config.bar = 4

with tempfile.NamedTemporaryFile(mode='w', delete=False) as f:
f.write('--test_config.foo=7\n')
f.flush()
f.close()
values = _parse_flags(f'./program --flagfile={f.name}', config=config)
with tempfile.TemporaryDirectory(prefix='flag file ') as temp_dir:
filename = os.path.join(temp_dir, 'flags.txt')
with open(filename, 'w') as f:
f.write('--test_config.foo=7\n')
values = _parse_flags(
f'./program --flagfile={shlex.quote(filename)}', config=config)
self.assertEqual(values.test_config.foo, 7)
self.assertEqual(values.test_config.bar, 4)

Expand Down
Loading