Repository navigation
test: quote and clean up temporary flagfile paths - #79
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConfigDictFlagTest.testFlagfilefails on Windows because_parse_flagsusesshlex.split, which consumes backslashes in the unquoted temporary filename. The same command breaks when the temporary directory contains spaces. The test also leaves itsdelete=Falsefile behind.Quote the filename for the test command and use a temporary directory that cleans up the file. Give that directory a space-containing prefix so the test exercises the quoting requirement on other platforms too. The file is closed before parsing.
Validation: reproduced the original failure on unchanged upstream on Windows. Config-dict and config-flags suites now pass without deselecting that test: 386 passed, 8 subtests passed, 1 skipped.
git diff --checkpasses.