Skip to content

Limit add-chain/add-pre-chain request body size to prevent memory exh… #1815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ztzat089-ctrl wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −0
Open

Limit add-chain/add-pre-chain request body size to prevent memory exh… #1815

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions trillian/ctfe/handlers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ var (
)

const (
maxAddChainBodyBytes int64 = 512000 // limits add-chain/add-pre-chain body size to prevent memory exhaustion
// HTTP Cache-Control header
cacheControlHeader = "Cache-Control"
// Value for Cache-Control header when response contains immutable data, i.e. entries or proofs. Allows the response to be cached for 1 day.
Expand Down Expand Up @@ -464,6 +465,7 @@ func addChainInternal(ctx context.Context, li *logInfo, w http.ResponseWriter, r
}

// Check the contents of the request and convert to slice of certificates.
r.Body = http.MaxBytesReader(w, r.Body, maxAddChainBodyBytes)
addChainReq, err := ParseBodyAsJSONChain(r)
if err != nil {
var maxBytesErr *http.MaxBytesError
Expand Down