Limit add-chain/add-pre-chain request body size to prevent memory exh… - #1815
Open
ztzat089-ctrl wants to merge 1 commit into
Open
Limit add-chain/add-pre-chain request body size to prevent memory exh…#1815ztzat089-ctrl wants to merge 1 commit into
ztzat089-ctrl wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an unbounded memory allocation vulnerability in the add-chain
and add-pre-chain HTTP handlers.
ParseBodyAsJSONChainreads the entirerequest body via
io.ReadAll(r.Body)without any size limit, allowing amalicious client to send an oversized request and exhaust server memory.
Fix
Applies
http.MaxBytesReadertor.Bodybefore it reachesParseBodyAsJSONChain, limiting the body to 512000 bytes (matching theexisting
maxAddChainBodyBytesconstant already used insubmission/proxy_server.go). The error-handling code inaddChainInternalalready expected an
http.MaxBytesError, but nothing triggered it on thedirect CTFE path — only the proxy path was protected.
Testing
go build ./trillian/ctfe/...passesgo test ./trillian/ctfe/...passes (all existing tests pass)Related
Reported via Google OSS VRP, Issue Tracker #542934724.