Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/midi/playback/MidiPlayer.js
Original file line number Diff line number Diff line change
Expand Up @@ -2049,8 +2049,7 @@ class MidiPlayer {
}

setChannelNoteRemapping(channel, mapping) {
const willHave =
mapping && typeof mapping === 'object' && Object.keys(mapping).length > 0;
const willHave = mapping && typeof mapping === 'object' && Object.keys(mapping).length > 0;
// Release held notes before the remap changes, else a note turned on under
// the old mapping is stranded when its note-off is emitted under the new one
// (audit axis6-2).
Expand Down
8 changes: 7 additions & 1 deletion src/midi/playback/PlaybackScheduler.js
Original file line number Diff line number Diff line change
Expand Up @@ -1128,7 +1128,13 @@ class PlaybackScheduler {
* @param {Array} channels - MIDI channels from file
*/
sendAllNotesOff(outputDevice, channelRouting, channels, resolveChannel = null) {
this._broadcastCC(outputDevice, channelRouting, channels, resolveChannel, MIDI_CC_ALL_NOTES_OFF);
this._broadcastCC(
outputDevice,
channelRouting,
channels,
resolveChannel,
MIDI_CC_ALL_NOTES_OFF
);
}

/**
Expand Down
10 changes: 8 additions & 2 deletions src/midi/playback/commands/PlaybackAssignmentCommands.js
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,9 @@ async function applyAssignments(app, data) {
}
}
} catch (playerErr) {
app.logger.warn(`Live routing update failed for ch ${resolvedCh}: ${playerErr.message}`);
app.logger.warn(
`Live routing update failed for ch ${resolvedCh}: ${playerErr.message}`
);
}
} catch (dbError) {
app.logger.warn(
Expand Down Expand Up @@ -568,7 +570,11 @@ async function applyAssignments(app, data) {
// into a reported failure (audit review).
try {
if (app.midiPlayer && app.midiPlayer.loadedFileId === targetFileId) {
app.midiPlayer.setChannelRouting(channelNum, assignment.deviceId, instrumentTargetChannel);
app.midiPlayer.setChannelRouting(
channelNum,
assignment.deviceId,
instrumentTargetChannel
);
if (typeof app.midiPlayer.setChannelTransposition === 'function') {
app.midiPlayer.setChannelTransposition(channelNum, runtimeSemitones(assignment));
}
Expand Down
4 changes: 3 additions & 1 deletion src/midi/routing/FileRoutingSyncService.js
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,9 @@ export function planChannelRouting({

// `skip-device` is retained for the caller's invalid-device reporting, but it
// now also carries the disabled routing so the caller can persist (not drop) it.
return deviceOffline ? { action: 'skip-device', deviceId, routing } : { action: 'insert', routing };
return deviceOffline
? { action: 'skip-device', deviceId, routing }
: { action: 'insert', routing };
}

export default class FileRoutingSyncService {
Expand Down