style: fix pre-existing Prettier drift merged onto main (restores green Lint CI) - #1897
Merged
Conversation
CI's `npm run format:check` (prettier --check over the full tree) was failing on four files carried over from earlier commits on this branch: PlaybackAssignmentCommands.js, MidiPlayer.js, PlaybackScheduler.js and FileRoutingSyncService.js. The husky pre-commit hook does not run in the `npm install --ignore-scripts` dev setup, so the drift was never caught locally. These are whitespace-only changes (long-line wrapping) with no logic change. Full suite still green: 107 suites / 1281 tests. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ekccgnr9tm3Jt5x91X5nHt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reformats 4 files with Prettier to clear pre-existing format drift. Formatting-only — whitespace / line-wrapping, no behavior change.
src/midi/playback/MidiPlayer.jssrc/midi/playback/PlaybackScheduler.jssrc/midi/playback/commands/PlaybackAssignmentCommands.jssrc/midi/routing/FileRoutingSyncService.js(+19 / −6)
Why
The audit work (#1896) merged onto
mainwith these 4 files not Prettier-clean, somaincurrently fails theLintjob'sformat:checkstep (prettier --check→ exit 1). This fix existed but stayed on the feature branch after #1896 merged. Since #1896 is merged, landing it requires this fresh PR — otherwise any new PR againstmaininherits the redformat:check.Verification (local, exact CI commands)
npm run format:check→All matched files use Prettier code style!— exit 0npm run lint→ 0 errors (202 pre-existingno-console/ unused-var warnings, non-blocking) — exit 0Both halves of the
Lintjob pass. The commit is formatting-only, so it can't affecttypecheck, backend, or frontend jobs.🤖 Generated with Claude Code
https://claude.ai/code/session_01Ekccgnr9tm3Jt5x91X5nHt
Generated by Claude Code