Repository navigation
giottoTree records the features it was built from - #1323
Merged
Merged
Conversation
jiajic
changed the title
jiajic
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
calculateClusterTree()now records the features it correlated asattr(tree, "params")$feats:NULLwhen every feature was usedBefore, it recorded only the count (
n_feats), so a tree couldn't say which genes built its branches. This is provenance, alongside the other settings the tree already records.Test:
test_03_giotto_tree.Rchecks thatfeatsisNULLwith no restriction, and otherwise records only the features present (a requested feature absent from the data is dropped, andn_featsagrees). All cluster-tree test files pass: 29 tests, 139 expectations.(A
plot(tree, what = "heatmap")method was briefly described here after this PR had merged. It isn't part of this PR; it's in giotto-suite/GiottoVisuals#156.)🤖 Generated with Claude Code