[Sis integration] params for import/export - #47
Merged
Conversation
EssKayz
changed the title
EssKayz
force-pushed
the
sis-integration-params
branch
2 times, most recently
from
June 25, 2026 17:53
54c79b4 to
2a48b52
Compare
EssKayz
force-pushed
the
sis-integration-params
branch
from
June 25, 2026 18:47
6185a42 to
f462688
Compare
EssKayz
force-pushed
the
sis-integration-params
branch
from
June 25, 2026 18:52
f462688 to
2740b41
Compare
EssKayz
commented
Jun 26, 2026
xTooth
approved these changes
Jun 29, 2026
xTooth
left a comment
xTooth
left a comment
Contributor
There was a problem hiding this comment.
The comments are minor, and dont affect functionality. I think we can proceed with this for now and (hopefully) address these items on at a later time when this inevitably gets refactored again 😄
Import statistics did not get altered in local testing. so seems to work as intended all together.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
paramsmethod possibilities for both import and export endpoints.technically allows for overriding of
limitetc on exports, but that could maybe be handled in the future if we feel it's required.