[Sis integration] try to handle failingids - #49
Merged
Conversation
EssKayz
force-pushed
the
sis-integration-failingids
branch
3 times, most recently
from
June 26, 2026 12:00
b354197 to
80314fc
Compare
EssKayz
force-pushed
the
sis-integration-failingids
branch
from
June 29, 2026 12:08
80314fc to
34011c3
Compare
xTooth
approved these changes
Jun 29, 2026
xTooth
left a comment
xTooth
left a comment
Contributor
There was a problem hiding this comment.
Works. The import function is starting to be quite large. We might want to refactor that at some point into smaller segments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NB -- based on the sis-integration-params branch (#47) to see that same tests pass with new code
since sometimes Sisu will provide us with a failingIds listing, we could attempt to use that to easier fork through "where" the errors are, and find the failures much faster instead of randomly/binomially searching.