Skip to content

fix: remove the max batch limit #2962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pedrogameiro wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: remove the max batch limit #2962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions charts/kuberpult/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,8 +267,7 @@ manifestRepoExport:
# its single push must finish comfortably within `networkTimeoutSeconds` above (NOT
# `git.networkTimeout`, which governs the cd-service). An oversized batch that trips the timeout
# forces the whole batch to reprocess, which is strictly worse than not
# batching. Must be between 1 and 100 (inclusive); the service rejects values
# above 100. This is a hard guard against having a excessive configuration.
# batching. Must be at least 1; there is no upper bound enforced by the service.
# For details, view `docs/operators/timeouts.md`.
maxExportBatchSize: 1

Expand Down
6 changes: 0 additions & 6 deletions services/manifest-repo-export-service/pkg/cmd/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,6 @@ const (
maxReleaseVersionsLimit = 30

maxEslProcessingTimeSeconds int64 = 600 // see eslProcessingIdleTimeSeconds in values.yaml

// maxExportBatchSizeLimit is a hard upper bound on KUBERPULT_MAX_EXPORT_BATCH_SIZE.
maxExportBatchSizeLimit = 100

@sven-urbanski-freiheit-com sven-urbanski-freiheit-com Jul 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to increase the maximum (.e.g 1k) threshold instead of removing it. That way we still have a sanity check, and 1k should be enough for everyone.

)

func RunServer() {
Expand Down Expand Up @@ -189,9 +186,6 @@ func Run(ctx context.Context) error {
if maxExportBatchSize == 0 {
return fmt.Errorf("error KUBERPULT_MAX_EXPORT_BATCH_SIZE must be >=1 but was: %v", maxExportBatchSize)
}
if maxExportBatchSize > maxExportBatchSizeLimit {
return fmt.Errorf("error KUBERPULT_MAX_EXPORT_BATCH_SIZE must be <=%v but was: %v", maxExportBatchSizeLimit, maxExportBatchSize)
}
logging.Info(ctx, "maxExportBatchSize", zap.Uint("maxExportBatchSize", maxExportBatchSize))

networkTimeoutSecondsStr, err := valid.ReadEnvVar("KUBERPULT_NETWORK_TIMEOUT_SECONDS")
Expand Down
Loading