fix: remove the max batch limit - #2962
Open
pedrogameiro wants to merge 1 commit into
Open
Conversation
After some practical experience with using the batch feature, it became clear that the overhead of batching is smaller than I expected. With no measurable increase of latency even for big values.
| maxEslProcessingTimeSeconds int64 = 600 // see eslProcessingIdleTimeSeconds in values.yaml | ||
|
|
||
| // maxExportBatchSizeLimit is a hard upper bound on KUBERPULT_MAX_EXPORT_BATCH_SIZE. | ||
| maxExportBatchSizeLimit = 100 |
Contributor
There was a problem hiding this comment.
I would prefer to increase the maximum (.e.g 1k) threshold instead of removing it. That way we still have a sanity check, and 1k should be enough for everyone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After some practical experience with using the batch feature, it became clear that the overhead of batching is smaller than I expected. With no measurable increase of latency even for big values.