Fix search showing limited results by carma12 · Pull Request #1139 · freeipa/freeipa-webui

carma12 · 2026-07-13T13:04:13Z

Fix search from non-first pages returning
wrong or empty results

Reset pagination to page 1 and use startIdx: 0
when submitting a search. Previously, search used
the current page offset, which skipped matching
entries in the LDAP result set. Fixed across all
affected pages, and updated the corresponding
main-pages file.

Assisted-by: Claude noreply@anthropic.com

Summary by Sourcery

Reset search pagination and result indices so searches always start from the first page and return complete results across all affected listing pages.

Bug Fixes:

Fix searches performed from non-first pages returning empty or incomplete results by resetting to page 1.
Ensure LDAP-backed searches consistently query from the first result up to the current page size instead of using paginated offsets.

Documentation:

Update the main-pages walkthrough design document to reflect the corrected search pagination behavior.

sourcery-ai

Hey - I've left some high level feedback:

The submitSearchValue logic (resetting page to 1 and using startIdx: 0/stopIdx: perPage) is duplicated across many pages; consider extracting a shared hook or helper to keep this behavior consistent and easier to maintain.
Where the page number is shown in the UI, verify that resetting setPage(1) on search aligns with user expectations (e.g., when clearing search or changing filters) so pagination indicators don’t become inconsistent with the underlying data.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The `submitSearchValue` logic (resetting page to 1 and using `startIdx: 0`/`stopIdx: perPage`) is duplicated across many pages; consider extracting a shared hook or helper to keep this behavior consistent and easier to maintain.
- Where the page number is shown in the UI, verify that resetting `setPage(1)` on search aligns with user expectations (e.g., when clearing search or changing filters) so pagination indicators don’t become inconsistent with the underlying data.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

veronnicka

Hi, I tried the changes and the bug seems to be still there, I was trying it in the hbac rules pages.

Screencast.From.2026-07-13.15-54-53.mp4

upon the first enter, it just changes to the first page and upon the second click it actually searches for the name

EDIT: the active users are working, I think this difference might be because of the responsive search upon each keystroke? but that is just a guess

duzda · 2026-07-14T08:40:28Z

-      startIdx: firstIdx,
-      stopIdx: lastIdx,
+      startIdx: 0,
+      stopIdx: perPage,


Won't this limit the search to only perPage entries? What if I have more entries than that? How can I search for them?

You are right. Not sure why this was changed like that...

veronnicka

Thanks, I tried Active users and Hbac rules pages again and it works as expected. You even fixed the responsive search, so we should add Fixes: #1138

I think there is a redundant setPage(1) in the solution so please look into that.

I noticed that the changes are not consistent and decided to dig a bit into it, then I also noticed some files were not touched and are still not working, I am sending a screenshot from Claude:

I checked the OtpTokens in the UI and the bug is still present. The list is just orientational, but a good starting point. I suggest asking claude for incosistencies and then check it and make sure all files are fixed.

veronnicka · 2026-07-15T07:47:35Z

          }

          setUsersTotalCount(totalCount);
+          setPage(1);


why is it here again? you already set it at the begginning of the call

This is because, when a search is done from, e.g, page 2, the results are listed (and most likely will be one or more entries, but less than what's specified in perPage, e.g. 10), but the page is still located in 2 so the results cannot be seen. That's why I'm settings the page to the very beginning so that the data can be shown.

yes that I understand. But the setPage is done twice in the call, once at the very begginning a few lines up, and then again here.

carma12 · 2026-07-15T09:26:42Z

Thanks, I tried Active users and Hbac rules pages again and it works as expected. You even fixed the responsive search, so we should add Fixes: #1138

I think there is a redundant setPage(1) in the solution so please look into that.

I noticed that the changes are not consistent and decided to dig a bit into it, then I also noticed some files were not touched and are still not working, I am sending a screenshot from Claude:

I checked the OtpTokens in the UI and the bug is still present. The list is just orientational, but a good starting point. I suggest asking claude for incosistencies and then check it and make sure all files are fixed.

I didn't realized about the responsive search until you mentioned it, haha. I have already fixed the changes mentioned and I have tested it in DNS zones page. Could you please confirm that everything works fine in your end? TY!

duzda · 2026-07-15T09:59:09Z

+> **Important — `stopIdx: 100`:** Use a fixed upper bound (100) instead of `perPage`.
+> The LDAP backend has a size limit close to this value, and using `perPage` (e.g. 10)
+> would miss entries beyond the first page of results when searching from a page other
+> than page 1.


It's not an LDAP limitation, it's a global setting, that is overridable

I think we could even omit the stopIdx.

https://webui.ipa.test/ipa/ui/#/e/config/details

Right. But even if you put a wild number like, e.g. 1000 there, the limitation will be around ~200 elements.

veronnicka · 2026-07-15T10:42:20Z

Thanks, I tried Active users and Hbac rules pages again and it works as expected. You even fixed the responsive search, so we should add Fixes: #1138
I think there is a redundant setPage(1) in the solution so please look into that.
I noticed that the changes are not consistent and decided to dig a bit into it, then I also noticed some files were not touched and are still not working, I am sending a screenshot from Claude:

I checked the OtpTokens in the UI and the bug is still present. The list is just orientational, but a good starting point. I suggest asking claude for incosistencies and then check it and make sure all files are fixed.

I didn't realized about the responsive search until you mentioned it, haha. I have already fixed the changes mentioned and I have tested it in DNS zones page. Could you please confirm that everything works fine in your end? TY!

I dont see any recent push(aybe some issue on my end?), will wait for that then check.

carma12 · 2026-07-15T12:16:33Z

Thanks, I tried Active users and Hbac rules pages again and it works as expected. You even fixed the responsive search, so we should add Fixes: #1138
I think there is a redundant setPage(1) in the solution so please look into that.
I noticed that the changes are not consistent and decided to dig a bit into it, then I also noticed some files were not touched and are still not working, I am sending a screenshot from Claude:

I checked the OtpTokens in the UI and the bug is still present. The list is just orientational, but a good starting point. I suggest asking claude for incosistencies and then check it and make sure all files are fixed.

I didn't realized about the responsive search until you mentioned it, haha. I have already fixed the changes mentioned and I have tested it in DNS zones page. Could you please confirm that everything works fine in your end? TY!

I dont see any recent push(aybe some issue on my end?), will wait for that then check.

I pushed them. But I can do the push again...

veronnicka

Hi, I tried running it, looked into Hbac rules, Active users, User groups and all seems to work great. Thanks for the effort. Just one comment in the doc, please add the Fixes: as I suggested, other than that we can merge. Providing an ack

veronnicka · 2026-07-16T08:43:17Z

            elementsList: entities,
            totalCount: searchTotalCount,
          });
+          setPage(1);


the code no longer calls the setPage in the success branch so please remove from the doc as well

Sure, will do it.

Fix search from non-first pages returning wrong or empty results Reset pagination to page 1 and use `startIdx: 0` when submitting a search. Previously, search used the current page offset, which skipped matching entries in the LDAP result set. Fixed across all affected pages, and updated the corresponding `main-pages` file. Assisted-by: Claude <noreply@anthropic.com> Signed-off-by: Carla Martinez <carlmart@redhat.com>

carma12 added the needs-review This PR is waiting on a review label Jul 13, 2026

sourcery-ai Bot reviewed Jul 13, 2026

View reviewed changes

This was referenced Jul 13, 2026

'Privileges' main page #1134

Merged

Roles > 'Privileges' page #1132

Merged

carma12 force-pushed the fix-search-limited-results branch from 1371ef1 to 5823bdc Compare July 13, 2026 13:40

veronnicka requested changes Jul 13, 2026

View reviewed changes

duzda reviewed Jul 14, 2026

View reviewed changes

carma12 force-pushed the fix-search-limited-results branch 2 times, most recently from 18fb8c3 to da4d9d7 Compare July 14, 2026 13:46

veronnicka reviewed Jul 15, 2026

View reviewed changes

duzda reviewed Jul 15, 2026

View reviewed changes

carma12 force-pushed the fix-search-limited-results branch from 63d00a2 to ba2ccff Compare July 15, 2026 12:16

veronnicka approved these changes Jul 16, 2026

View reviewed changes

carma12 force-pushed the fix-search-limited-results branch from ba2ccff to a74c373 Compare July 16, 2026 09:00

veronnicka mentioned this pull request Jul 16, 2026

OTP tokens > 'Is managed by' subpage #1137

Open

Uh oh!

Conversation

carma12 commented Jul 13, 2026 • edited by sourcery-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by Sourcery

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

veronnicka left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

veronnicka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

carma12 Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

carma12 commented Jul 15, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

veronnicka commented Jul 15, 2026

Uh oh!

carma12 commented Jul 15, 2026

Uh oh!

veronnicka left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

carma12 commented Jul 13, 2026 •

edited by sourcery-ai Bot

Loading

veronnicka left a comment •

edited

Loading

carma12 Jul 15, 2026 •

edited

Loading