'Privileges' main page

[carma12]

The 'Privileges' page should be located under 'Role-based access control' section and must show all the available privileges associated to the IPA server.

This PR has been built in the top of #1126 , so it must be merged first.

Assisted-by: Claude noreply@anthropic.com

[sourcery-ai]

Sorry @carma12, your pull request is larger than the review limit of 150000 diff characters

[veronnicka]

There is really a lot of changes this PR is built on, so I will wait for the rebase.

[carma12]

@veronnicka - This PR is now ready to review.

[duzda]

Hi, the help panel is not working

[duzda]

Hi @carma12,

the help panel is not working

[carma12]

Hi @carma12,

the help panel is not working

I completely overlooked this, sorry 😅 Will fix...

[carma12]

@duzda - The code has been fixed based on your feedback (including the missing Contextual help links panel).

[veronnicka]

Hi, theres a bug when searching on a page other than the first one(the search on the first page works)

Search uses the current pagination offset (firstIdx / lastIdx) and a fix I propose would be to look in all of the results, so something like :

const submitSearchValue = () => {
  setPage(1);
  ...
  searchPrivileges({
    ...
    startIdx: 0,
    stopIdx: perPage,
  })
}

[veronnicka]

Another thing I noticed, the search is not responsive- it only searches the value after clicking enter. The other pages implemented do have the reponsive approach, so the list in the table changes with each key put into the search. Is this something we want to address?

[carma12]

Hi, theres a bug when searching on a page other than the first one(the search on the first page works)

Search uses the current pagination offset (firstIdx / lastIdx) and a fix I propose would be to look in all of the results, so something like :

const submitSearchValue = () => {
  setPage(1);
  ...
  searchPrivileges({
    ...
    startIdx: 0,
    stopIdx: perPage,
  })
}

Nice catch, will check this asap...

[carma12]

Another thing I noticed, the search is not responsive- it only searches the value after clicking enter. The other pages implemented do have the reponsive approach, so the list in the table changes with each key put into the search. Is this something we want to address?

You are right: there is an inconsistency on how the data is being searched. I will fix this in this PR, but also will open a new PR to do it in other pages affected.

[carma12]

Hi, theres a bug when searching on a page other than the first one(the search on the first page works)
Search uses the current pagination offset (firstIdx / lastIdx) and a fix I propose would be to look in all of the results, so something like :

const submitSearchValue = () => {
  setPage(1);
  ...
  searchPrivileges({
    ...
    startIdx: 0,
    stopIdx: perPage,
  })
}

Nice catch, will check this asap...

This has been fixed in the code. Thank you!

[carma12]

Another thing I noticed, the search is not responsive- it only searches the value after clicking enter. The other pages implemented do have the reponsive approach, so the list in the table changes with each key put into the search. Is this something we want to address?

You are right: there is an inconsistency on how the data is being searched. I will fix this in this PR, but also will open a new PR to do it in other pages affected.

I fixed the issue unrelated to this PR in this PR: #1139

[veronnicka]

The changes here fixed the search- it reacts on the first click of the button, but Im a bit unsure about the results, please see the screenshots attached.

[carma12]

The changes here fixed the search- it reacts on the first click of the button, but Im a bit unsure about the results, please see the screenshots attached.

The results are provided by the privileges_find API call, that performs an LDAP search in the DS, so there is no much that we can do in terms of the accuracy (or lack of it) that we get. This most likely will also happen in the old WebUI...

[duzda]

It is a bit counterintuitive to how elsewhere search works, but let's keep it this way.

[veronnicka]

The changes here fixed the search- it reacts on the first click of the button, but Im a bit unsure about the results, please see the screenshots attached.

The results are provided by the privileges_find API call, that performs an LDAP search in the DS, so there is no much that we can do in terms of the accuracy (or lack of it) that we get. This most likely will also happen in the old WebUI...

Okay, I thought it might be something like that but wasnt sure. Thanks for the explanation!

[veronnicka]

I have no further comments, providing an ack