Repository navigation
fix(downloads): treat transient network and rate-limit errors as transient - #301
Merged
Merged
Conversation
Offline, timeouts, HTTP 429 and 5xx no longer poison the 24 hour link cache; genuine dead links are still cached. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DGbCKVdcUfJfjZ93bYY9p3
GoFile transport errors were reported as link errors, so going offline discarded the partial file. They now map to ResolveError::Network and keep the partial download. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DGbCKVdcUfJfjZ93bYY9p3
1fichier waits, Buzzheavier and GoFile rate limits and HTTP 429 now carry the host's Retry-After (bounded) and the mirror retry loop sleeps that long instead of 250 ms, so a resumable download is not burned in a second. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DGbCKVdcUfJfjZ93bYY9p3
This was referenced Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Three download pipeline fixes from the review, one commit each:
inspectis now aNetworkerror. NewResolveError::is_transient().ResolveError::Network, so going offline keeps the partial file instead of treating it as a broken link.GofileErrorgains aNetworkvariant.ResolveError::RateLimited { message, retry_after }for 1fichier wait notices, Buzzheavier 429 and browser checks, GoFile rate limits and generic 429. The mirror retry loop now sleeps the stated wait (default 30s, clamped 1s to 300s, cancellable) instead of 250 ms. A rate-limited retry still counts toward the mirror's 4 attempts.download_queue.rsis touched minimally (newTransferError::RateLimited, oneFromarm, the retry delay, a Display arm). It may conflict lightly with the queue scheduling PR.Validation
cargo test965 passed, 0 failed;cargo clippy --all-targets -D warningsandcargo fmt --checkclean.transient_failures_are_not_cacheable,network_failures_stay_network_errors,rate_limit_delay_respects_the_host_within_bounds, plus 1fichier wait-notice assertions.Generated by Claude Code