Repository navigation
fix: delete downloaded archive after successful install - #305
Merged
Merged
Conversation
The archive and its partial file were kept until the user cleared the list. Remove them with the stage cleanup once the install is committed; a deletion failure is logged and does not fail the install. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DGbCKVdcUfJfjZ93bYY9p3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Review finding H6: the downloaded archive was only deleted on a manual "clear list", so it stayed on disk forever after a successful install.
cleanup_stageinfinalize_install.rsnow also deletes<id>.archiveand<id>.partfrom the downloads directory (newremove_download_fileshelper).application_log::failureand does not fail the install.cleanup_stagealso runs fromrecover_cleanupat startup, so installs interrupted after commit get cleaned too.installed(staging only runs fordownloaded,recover_stagingonly looks atstagingrows,remove_entryalready ignores a missing file).No changes to
download_queue.rs; no textual conflicts with #301 and #302.Validation
install_removes_downloaded_archive;finalize_installanddownload_queuetests pass; clippy-D warningsandcargo fmt --checkclean.Generated by Claude Code