Refactor 'bcftbx.TabFile' module into new module 'bcftbx.io.tabular' - #241
Merged
Conversation
…nd 'TabFileIterator'. Reimplements internals of the 'TabFile' and 'TabFileIterator' classes to pass the creation of new TabFile and TabLine instances to an internal helper function. Also removes the 'tab_data_line' argument from the 'TabFile' initialiser (so only TabLines are now supported).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reimplements the functionality from the
bcftbx.TabFilemodule in a new modulebcftbx.io.tabular.The
io.tabularmodule reimplements theTabFileandTabFileIteratorclasses with more pythonic names for methods; it also reimplements the legacyTabDataLineas a newTabLineclass, which simplifies how data is supplied on initialisation.The existing
TabFilemodule has been retained as a "legacy" module and the classes within it now reimplemented as subclasses of those intabular.The
platforms.illumina.samplesheetmodule has been updated to use the newio.tabularlibrary.Any legacy modules using the
TabFilemodule have not been updated.Part of changes to address issue #33.