Repository navigation
fix(publish): publish tarball by ./ path - #23
Merged
Merged
Conversation
…tHub spec npm parses `artifacts/fleetbase-storefront-1.2.0.tgz` as the GitHub shorthand `artifacts/<repo>` and tries to git ls-remote it, which failed the v1.2.0 Publish run with "Permission denied (publickey)".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
publish.ymlrannpm publish artifacts/*.tgz. npm treatsartifacts/fleetbase-storefront-1.2.0.tgzas GitHub shorthand (owner/repo) and runsgit ls-remote ssh://git@github.com/artifacts/fleetbase-storefront-1.2.0.tgz.git, so the v1.2.0 Publish run failed withPermission denied (publickey). As a result, npm still shows 1.1.14 and there's no GitHub Release for v1.2.0, even though the Release Tag workflow pushed the tag.Fix: pass
./artifacts/*.tgzso npm resolves it as a local file.Validation
npm publish --dry-run artifacts/fleetbase-storefront-1.2.0.tgzreproduces the git error locally.npm publish --dry-run ./artifacts/fleetbase-storefront-1.2.0.tgzresolves+ @fleetbase/storefront@1.2.0.artifacts/*.tgzuses (ci.yml, the verify scripts) go through node scripts orupload-artifact, not npm spec parsing, so they're unaffected.Follow-up
The
v1.2.0tag points at the commit with the broken workflow, so re-running that Publish run will fail again. After this merges, v1.2.0 has to be re-tagged on the fixed commit, or the fix has to ship as v1.2.1.No API, docs, or spec impact.