Repository navigation
fix(publish): pass NPM_AUTH_TOKEN to npm publish - #24
Merged
Merged
Conversation
Org secrets only reach a job when the workflow references them. publish.yml never did, so npm received setup-node's placeholder token and the v1.2.0 publish was rejected with E404 on PUT. Matches fleetbase-js and fleetops.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
After #23, the v1.2.0 Publish run got as far as the upload and then failed:
publish.ymlnever referencessecrets.NPM_AUTH_TOKEN. Org secrets only reach a job when the workflow names them, so npm received only setup-node'sXXXXX-XXXXX-XXXXX-XXXXXplaceholder. This PR passes the org token asNODE_AUTH_TOKENon the publish step, the same way fleetbase-js (release.yml) and fleetops (ember.yml) already do.Validation
NODE_AUTH_TOKEN: XXXXX-XXXXX-XXXXX-XXXXX, which is setup-node's placeholder used when no token is given.grepshows no reference toNPM_AUTH_TOKENanywhere in storefront-js before this change.Follow-up
After this merges, move the
v1.2.0tag to the merge commit so Publish runs again with the token. 1.2.0 is still not on npm and has no GitHub Release.No API, docs, or spec impact.