Repository navigation
test: run the suite against core-api 1.6.69 - #399
Merged
Merged
Conversation
The fixture customer has an email, so the refusal fell back to email and answered 200 where the test expects the guard's 429. Never ran green: PHP CI could not resolve core-api ^1.6.69 until it was tagged.
roncodes
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes PHP CI / build on #372 now that
fleetbase/core-api1.6.69 resolves and the suite runs against the real core for the first time. Every test file was run locally throughscripts/pest-runner.php(507 files): three failed, all test-side.ApiCustomerControllerContractsTest: the "over budget with no email on file" case used the shared fixture customer, who has an email, sologinWithPhonecorrectly fell back to email (200) instead of surfacing the 429. The test clears the email for that case.DriverControllerAuthFlowsTest(4 tests): the harness never turned the core SMS guard off, so its counters lived in the shared array cache and a second text to the same number inside a file tripped the 60-second cooldown: a 429 "Try again in a minute" where the tests expect the transport failure or the refusal they stage from the provider fake.scripts/pest-bootstrap.phpnow seedssms.guard.enabled = false, the same default core-api's and storefront's bootstraps use.CustomerControllerHelperSeamsTest: the verification-code seam test reused one code for two lookups and omitted the purpose. A code is used up by the lookup that accepts it, and the live-code query is per purpose, so each check gets its own row and carriesfor.No controller changes.