Repository navigation
test: run the suite against core-api 1.6.69 and cover what its coverage gate flags - #401
Merged
Merged
Conversation
… its own row Against core-api 1.6.69 the suite hit the real guard with its counters in the shared cache: a second text to the same number inside a file tripped the 60-second cooldown, so driver login tests got a 429 refusal where they expect the transport failure or the refusal they staged themselves. The bootstrap now seeds sms.guard.enabled = false, as core-api's and storefront's do; the tests that exercise refusals raise them from the provider fake. The helper-seams test reused one code for two lookups and omitted the purpose; a code is used up by the lookup that accepts it and the live-code query is per purpose, so each check gets its own row and carries 'for'.
The gate never ran before: the suite failed first. With the tests passing it reports 57 statements short across the order edit, its event, notifications, policy, tracking publisher, payload sync and the controllers that begin and refuse edits. This covers them: an edit's policy, marked changes, schedule, cash, contact and item detection with the kitchen flag, orders with no or an unsaved payload, the summary's fallbacks; order.changed's customer channel, session editor, missing driver and null place; push builders reaching for the FCM and APN clients; a config that cannot answer, cannot load, and times that do not parse; route changes queued for tracking; caching switched off; the controllers' begin, locked-edit and switched-payload cash paths; replaced drivers told on bulk assignment; and the entity sync's non-array inputs. The older-core branch in ApiCacheThrottle::telemetryWrite() cannot run against the core this package requires and is marked for coverage with the reason.
roncodes
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/v0.6.72 #401 +/- ##
=====================================================
Coverage 100.00% 100.00%
- Complexity 12379 13585 +1206
=====================================================
Files 600 634 +34
Lines 46496 49308 +2812
=====================================================
+ Hits 46496 49308 +2812
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #399, which was merged before its second commit landed on the branch. Together these turn PHP CI / build on #372 green.
1. Harness and seam fixes (the commit #399 missed):
DriverControllerAuthFlowsTest(4 tests): the harness never turned the core SMS guard off, so its counters lived in the shared array cache and a second text to the same number inside a file tripped the 60-second cooldown.scripts/pest-bootstrap.phpnow seedssms.guard.enabled = false, the default core-api's and storefront's bootstraps already use; the tests that exercise refusals raise them from the provider fake.CustomerControllerHelperSeamsTest: a code is used up by the lookup that accepts it and the live-code query is per purpose, so each check gets its own row and carriesfor.2. The 100% coverage gate. It had never run on this branch (the suite failed first). With the tests passing it reported 57 statements short across 13 files of the order-operations work (
OrderEdit,Events\\OrderChanged, the two push notifications,OrderEditPolicy,TrackingPublisher,Payload::syncEntities,ApiCacheThrottleand the edit seams in the API payload, entity and order controllers and the internal order controller). The second commit covers every one of them with tests; the one branch that cannot run against the required core (ApiCacheThrottle::telemetryWrite()for a core withoutwithoutInvalidating()) carries a narrow@codeCoverageIgnorewith the reason.Locally all 507 test files pass through
scripts/pest-runner.phpagainstfleetbase/core-api1.6.69, and a coverage run over the files that exercise those 13 classes shows every flagged line covered. No runtime behaviour changes.