Skip to content

fix(routes): throttle the public SMS-sending routes per address #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roncodes merged 1 commit into from
Oct 13, 2026
Merged

fix(routes): throttle the public SMS-sending routes per address #393

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions server/src/routes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,16 @@ function ($router) {
// drivers routes
$router->group(['prefix' => 'drivers', 'middleware' => []], function () use ($router) {
$router->post('register-device', 'DriverController@registerDevice');
$router->post('login-with-sms', 'DriverController@loginWithPhone');
// Routes that send a text message carry a small per-address bucket on top
// of the API credential throttle; the SMS guard in core bounds the spend.
$router->post('login-with-sms', 'DriverController@loginWithPhone')->middleware('throttle:5,1,fleetops-sms');
$router->post('verify-code', 'DriverController@verifyCode');
$router->post('login', 'DriverController@login');
// Password management. Deliberately separate from the driver
// update: changing a password requires proving the old one, and
// resetting it requires a code, neither of which a general PUT
// can express.
$router->post('forgot-password', 'DriverController@forgotPassword');
$router->post('forgot-password', 'DriverController@forgotPassword')->middleware('throttle:5,1,fleetops-sms');
$router->post('reset-password', 'DriverController@resetPassword');
$router->post('{id}/change-password', 'DriverController@changePassword');
$router->post('{id}/simulate', 'DriverController@simulate');
Expand Down Expand Up @@ -97,12 +99,12 @@ function ($router) {
// - Authenticated endpoints: API key + `Customer-Token` header (Sanctum)
$router->group(['prefix' => 'customers', 'middleware' => []], function () use ($router) {
// Public auth flows
$router->post('request-creation-code', 'CustomerController@requestCreationCode');
$router->post('request-creation-code', 'CustomerController@requestCreationCode')->middleware('throttle:5,1,fleetops-sms');
$router->post('/', 'CustomerController@create');
$router->post('login', 'CustomerController@login');
$router->post('login-with-sms', 'CustomerController@loginWithPhone');
$router->post('login-with-sms', 'CustomerController@loginWithPhone')->middleware('throttle:5,1,fleetops-sms');
$router->post('verify-code', 'CustomerController@verifyCode');
$router->post('forgot-password', 'CustomerController@forgotPassword');
$router->post('forgot-password', 'CustomerController@forgotPassword')->middleware('throttle:5,1,fleetops-sms');
$router->post('reset-password', 'CustomerController@resetPassword');

// Authenticated (require Customer-Token)
Expand Down
Loading