Repository navigation
fix(routes): throttle the public SMS-sending routes per address - #393
Merged
Merged
Conversation
Driver and customer login-with-sms, forgot-password and request-creation-code get a 5-a-minute bucket per address on top of the API credential throttle. An extra layer only: core's SmsGuard budgets bound the spend when an attacker has many addresses.
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Driver and customer
login-with-sms,forgot-passwordandrequest-creation-codeget athrottle:5,1,fleetops-smsbucket per address on top of the API credential throttle.This is an extra layer only. The spend bound for these endpoints comes from the SMS guard in core (fleetbase/core-api
feature/sms-guard), which every send already passes through viaSmsService; nothing in FleetOps needs to change for that.Follow-ups (not in this PR)
CustomerController::requestCreationCodepersists a stubUserbefore the identity is verified; that should go.Tests
Route-only change; the route recorders in the existing tests accept chained middleware. Not run locally; CI verifies.