Skip to content

fix(places): return 404 when a place isn't found #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roncodes merged 1 commit into from
Oct 9, 2026
Merged

fix(places): return 404 when a place isn't found #373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions server/src/Http/Controllers/Api/v1/PlaceController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ public function update($id, UpdatePlaceRequest $request)
try {
$place = $this->findPlaceOrFail($id);
} catch (\Illuminate\Database\Eloquent\ModelNotFoundException $exception) {
return $this->apiError('Place resource not found.');
return $this->apiError('Place resource not found.', 404);
}

// get request input
Expand Down Expand Up @@ -253,7 +253,7 @@ public function find($id, Request $request)
try {
$place = $this->findPlaceOrFail($id);
} catch (\Illuminate\Database\Eloquent\ModelNotFoundException $exception) {
return $this->apiError('Place resource not found.');
return $this->apiError('Place resource not found.', 404);
}

return $this->placeResource($place);
Expand All @@ -269,7 +269,7 @@ public function delete($id, Request $request)
try {
$place = $this->findPlaceOrFail($id);
} catch (\Illuminate\Database\Eloquent\ModelNotFoundException $exception) {
return $this->apiError('Place resource not found.');
return $this->apiError('Place resource not found.', 404);
}

$place->delete();
Expand Down
2 changes: 1 addition & 1 deletion server/tests/ApiPlaceControllerContractsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,5 +537,5 @@ function fleetopsApiPlace(array $attributes = []): FleetOpsApiPlaceEndpointFake
? $controller->update('missing-place', fleetopsUpdatePlaceRequest([]))
: $controller->{$method}('missing-place', new Request());

expect($response)->toBe(['apiError' => 'Place resource not found.', 'status' => 400]);
expect($response)->toBe(['apiError' => 'Place resource not found.', 'status' => 404]);
})->with(['update', 'find', 'delete']);
Loading