Repository navigation
fix(places): return 404 when a place isn't found - #373
Merged
Merged
Conversation
GET, PUT and DELETE /v1/places/{id} answered 400 for an unknown or
foreign place, unlike orders, vehicles, drivers and fleets.
Fixes #361
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #361
GET,PUTandDELETE /v1/places/{id}returned400 Place resource not found.for an unknown id or another organization's place, becausePlaceController::apiError()defaults to 400. Orders, vehicles, drivers and fleets return 404 in the same case.Changes
Api/v1/PlaceController.The lookup was already scoped to the company, so this only changes the status code.
Two related call sites stay as they are:
DriverController"Company not found." answers a badcompanyinput on create, so 400 still fits.CustomerController"Account not found." sits in the password-reset flow.Tests
php scripts/pest-runner.php server/tests/ApiPlaceControllerContractsTest.phpexits 0.