Skip to content

updated the readme.md - #36

Open
amitabh90 wants to merge 1 commit into
flatcar:mainfrom
amitabh90:flatcar-terrafrom/update-readme
Open

updated the readme.md#36
amitabh90 wants to merge 1 commit into
flatcar:mainfrom
amitabh90:flatcar-terrafrom/update-readme

Conversation

@amitabh90

Copy link
Copy Markdown

Title: enhances the flatcar-terraform/README.md documentation

issue 1848 : flatcar/Flatcar#1848

Description:

This PR enhances the flatcar-terraform/README.md documentation for better clarity, usability, and professionalism. The changes focus on navigation, consistency, and readability, making it easier for users and contributors to understand and use the repository. Changes Introduced

Signed-off-by: amitabh90 <amitabh90.das@gmail.com>
Comment thread README.md
Examples of deploying Flatcar instances with Terraform

# AWS EKS worker nodes
:warning: This is really for demo purposes but it can serve as a foundation (for example do not pass the admin configuration through HTTP for workers to join) :warning:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:warning: This is really for demo purposes but it can serve as a foundation (for example do not pass the admin configuration through HTTP for workers to join) :warning:
:warning: This is really for demo purposes: do not use those examples in production :warning:

Comment thread README.md
- [flatcar-terraform](#flatcar-terraform)
- [AWS EKS worker nodes](#aws-eks-worker-nodes)
- [Plain Flatcar instances](#plain-flatcar-instances)
- [digitalocean](#digitalocean)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally find this approach a bit less intuitive: one need to click here, to be redirected to L46-47 and one must click again on L46 to actually reach the digitalocean folder.

What about simply provide a list of all available examples in alphabetic order:

# Available examples
- [aws](aws)
- ...

Comment thread README.md
- [equinix-metal-aka-packet-without-instance-replacement](#equinix-metal-aka-packet-without-instance-replacement)
- [qemu-libvirt-without-instance-replacement](#qemu-libvirt-without-instance-replacement)

## flatcar-terraform

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep this as it is right now to have the following structure:

## flatcar-terraform

Examples of deploying Flatcar instances with Terraform/OpenTofu. Follow the README instructions in the directories to try it out.
<!-- The warning -->

# Available examples
- [aws](aws)
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants