Update AWS security group documentation to improve security guidance - #1872
Closed
adharsh277 wants to merge 2 commits into
Closed
Update AWS security group documentation to improve security guidance#1872adharsh277 wants to merge 2 commits into
adharsh277 wants to merge 2 commits into
Conversation
Contributor
|
Hi @adharsh277, thanks for your contribution but this not the right repository. This topic has already been discussed in the original issue and there is even a PR: flatcar/flatcar-terraform#36 |
Author
|
Thank you for the clarification, @tormath1 . I understand now that this documentation update belongs in the flatcar-terraform repository instead of here. I’ll review PR flatcar/flatcar-terraform#36 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update AWS security group documentation to improve security guidance
This PR enhances the README by adding best practices for configuring AWS security groups when provisioning EC2 instances with Terraform. It focuses on restricting SSH access, limiting public exposure, using variables for IP management, and encouraging regular audits of security groups. These changes provide practical guidance to users, even if the Terraform files are not present in the repository.
The update also references GitHub Issue #1848
to help maintainers and users understand the context of these recommendations.
How to use
Reviewers can validate this PR by checking the README changes for clear, actionable guidance on AWS security groups and SSH restrictions. No Terraform files are required to verify the documentation edits.
Testing done
Verified that the README markdown renders correctly on GitHub
Ensured all best practice points are clear and concise
No commands were run since this change is documentation-only
Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.