Hook up SUBDD-State_Diag for 3D StateMet tracers#99
Conversation
| ! TODO: State_Met%PEDGE | ||
|
|
||
| #ifdef CALC_MERRA2_LIKE_DIAGS | ||
|
|
||
| ! TODO: State_Met%PFICU | ||
| ! TODO: State_Met%PFILSAN | ||
| ! TODO: State_Met%PFLCU | ||
| ! TODO: State_Met%PFLLSAN | ||
|
|
||
| #endif |
There was a problem hiding this comment.
Oh actually, I don't see these in the HISTORY file so don't think they're needed.
There was a problem hiding this comment.
They appear in the "THE LevelEdgeDiags COLLECTION" rather than "The StateMet COLLECTION" so I guess we leave them out for now?
There was a problem hiding this comment.
Ah, now I see
# %%%%% The StateMet COLLECTION %%%%%
#
# Fields of the State_Met object (also see the LevelEdgeDiags collection)
I guess we can discuss on Tuesday.
Hook up other SUBDD-State_Diag for 3D `StateMet` tracers
| ! Dry air mass [kg] | ||
| ! TODO: State_Met%AD (II,JJ,K) = ??? | ||
|
|
||
| ! Dry air density [kg m-3] | ||
| ! TODO: State_Met%AIRDEN (II,JJ,K) = ??? | ||
|
|
||
| ! Volume of grid box [m3] | ||
| ! TODO: State_Met%AIRVOL (II,JJ,K) = ??? | ||
|
|
||
| ! Water vapor mixing ratio (w/r/t dry air) | ||
| ! TODO: State_Met%AVGW (II,JJ,K) = ??? | ||
|
|
||
| ! Grid box height [m] | ||
| ! TODO: State_Met%BXHEIGHT (II,JJ,K) = ??? |
There was a problem hiding this comment.
These fields are still TODO.
| ! Delta-pressure across grid box(wet air) [hPa] | ||
| ! TODO: State_Met%DELP (II,JJ,K) = ??? | ||
|
|
||
| ! Delta-pressure across grid box (dry air) [hPa] | ||
| ! TODO: State_Met%DELPDRY (II,JJ,K) = ??? |
There was a problem hiding this comment.
These fields are still TODO.
| ! Potential temperature [K] | ||
| ! TODO: State_Met%THETA (II,JJ,K) = ??? |
There was a problem hiding this comment.
This field is still TODO.
There was a problem hiding this comment.
@jwallwork23, let me do these fields right away. Thanks for the heads up!
There was a problem hiding this comment.
Apologies, these TODOs were for myself.
Unfortunately, what you pushed in cb3cba6 won't work because the arrays on the RHS need to come from the GISS model. In each case, we need to:
- Find out what the array is called in the GISS model.
- Add a
USE <module>, ONLY: <array>syntax at the top of the subroutine to import the array. - Add the indexed array on the RHS of the expression.
You'll notice that the coupled model CI builds failed with your commit because the arrays you added haven't been imported (and might not even have those names anyway).
|
Closing this PR as superseded by #102. |
2 participants
Towards #29.
Merges into #84.
This PR hooks up the 3D
StateMetfields.