Hook up other SUBDD-State_Diag for 3D StateMet tracers#100
Merged
Conversation
joewallwork
force-pushed
the
29_subdd-statediag-3d-extra
branch
from
1c3459f to
6a08a88
Compare
joewallwork
force-pushed
the
29_subdd-statediag-3d-extra
branch
from
6a08a88 to
81beba4
Compare
joewallwork
commented
Mar 17, 2025
Comment on lines
+441
to
+454
| ! Dry air mass [kg] | ||
| ! TODO: State_Met%AD (II,JJ,K) = ??? | ||
|
|
||
| ! Dry air density [kg m-3] | ||
| ! TODO: State_Met%AIRDEN (II,JJ,K) = ??? | ||
|
|
||
| ! Volume of grid box [m3] | ||
| ! TODO: State_Met%AIRVOL (II,JJ,K) = ??? | ||
|
|
||
| ! Water vapor mixing ratio (w/r/t dry air) | ||
| ! TODO: State_Met%AVGW (II,JJ,K) = ??? | ||
|
|
||
| ! Grid box height [m] | ||
| ! TODO: State_Met%BXHEIGHT (II,JJ,K) = ??? |
Collaborator
Author
There was a problem hiding this comment.
I still need to figure out where to get the data for these.
joewallwork
commented
Mar 17, 2025
Comment on lines
+465
to
+469
| ! Delta-pressure across grid box(wet air) [hPa] | ||
| ! TODO: State_Met%DELP (II,JJ,K) = ??? | ||
|
|
||
| ! Delta-pressure across grid box (dry air) [hPa] | ||
| ! TODO: State_Met%DELPDRY (II,JJ,K) = ??? |
joewallwork
commented
Mar 17, 2025
Comment on lines
+544
to
+545
| ! Potential temperature [K] | ||
| ! TODO: State_Met%THETA (II,JJ,K) = ??? |
joewallwork
commented
Mar 17, 2025
Comment on lines
+2290
to
+2299
| call inc_subdd(subdd,k,sddarr3d) | ||
| exit ntm_loop | ||
| end if | ||
| end do ntm_loop | ||
| enddo ! k | ||
| enddo ! igroup | ||
|
|
||
| do igrp=1,ngroups | ||
| subdd => subdd_groups(grpids(igrp)) | ||
| do k=1,subdd%ndiags |
Collaborator
Author
There was a problem hiding this comment.
I wasn't sure that we had the looping logic right here. I've separated it out for now but we should follow up in #99 once this is merged in.
AdelekeBankole
approved these changes
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #29.
Merges into #99.
This PR adds 3D diagnostics that weren't already included.
It also ensures that the correct units are used according to
GEOS-Chem/Headers/state_met_mod.F90and applies consistent formatting.