Hints

[wbazant]

Closes #1119

[cloudflare-workers-and-pages]

Deploying falling-fruit-web with    Cloudflare Pages

Latest commit:	bd70276
Status:	✅  Deploy successful!
Preview URL:	https://a6a077be.falling-fruit-web.pages.dev
Branch Preview URL:	https://issue-1119.falling-fruit-web.pages.dev

View logs

[ezwelty]

@wbazant Finally took it for a spin!

• I encountered the "Add description" frequently, and clicking it works as expected.
• Found "Add season stop" at 1919720 and works as expected.
  • It is season_stop in the database, but a better wording would be "Add season end"
• Found "Add season start" at 1554 and works as expected.
• The season hints need some layout tweaks. Top-vertical align the calendar icon and align start of new line with start of first line?

• I think "Report: no longer exists" is better as "Report no longer exists"
• I think "Edit description: still there" is better as "Confirm still exists" and link to the review form. I understand that you were avoiding the review form (which could lead to fragmented reviews), but reviews seem a better place for dated observations? Especially if we finally sort them by most recent first.
• I was somewhat surprised not to see "Add photo". Again to avoid the fragmented review problem?

[ezwelty]

@wbazant One more thing. Should we have something like a "Verify and edit" to unverified locations? Usually this is either the location is wrong or it has a single type that may be wrong, or it has multiple possible types, all but one is wrong. Unverified locations may also be candidates, regardless of age, for something "Report does not exist"

[wbazant]

The season hints need some layout tweaks. Top-vertical align the calendar icon and align start of new line with start of first line?

That's better! It degrades a bit if you make the window extra narrow in https://issue-1119.falling-fruit-web.pages.dev/locations/1919720 but I'm not sure how to wrap the hint, but not the text afterwards.

better wording would be "Add season end"
I think "Report: no longer exists" is better as "Report no longer exists"

Thanks! Made changes and re-translated.

I think "Edit description: still there" is better as "Confirm still exists" and link to the review form. I understand that you were avoiding the review form (which could lead to fragmented reviews), but reviews seem a better place for dated observations? Especially if we finally sort them by most recent first.

Changed this! Not sure what you mean about fragmented reviews, I was just trying to make the interaction make sense: the hint shows next to the date, so the action should make the date go up. The solution of changing the description achieved that but I agree 'still exists' is an observation. I switched to leaving a review, and introduced a 'last updated date' which is a max of last edit and reviews. Then after leaving the review, the date goes up, and the value is also more useful at assessing location freshness (it's now the last recorded interaction with it more generally).

I was somewhat surprised not to see "Add photo".

I ended up doing hints that fill in gaps and can't be turned off, this one would be quite annoying and not easy to bulk fix! Maybe one day as part of 'you approached this location' experience when we go fully pokemon go?

Should we have something like a "Verify and edit" to unverified locations?

Yeah would be good for explaining what 'unverified' means, too? I actually don't totally know myself what it means for imports. I made a demo so we can decide on the options shown, #1141

[wbazant]

I cleaned up the code a bit. I'll merge this one, and we can work on more hints as we get clarity on what options to offer.