Repository navigation
Conversation
This was referenced Sep 18, 2026
dazip
changed the title
Adds optional policy_preset (5) and an inline KeyPolicy policy (6) to CreateUserKeyRequest, and marks the legacy scope field deprecated and optional so an explicit ADMIN is distinguishable from an unset scope. Additive only: nothing behaves differently until the server reads them. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
dazip
force-pushed
the
prod-3005-v2-key-creation-via-fal-cli-preset-flags-interactive
branch
from
September 18, 2026 21:04
b4c934d to
67b52c1
Compare
dazip
force-pushed
the
prod-3005-keys-policy-preset-wire
branch
from
September 18, 2026 21:05
bf9a56e to
d226fdd
Compare
Presets now travel in policy_preset instead of the deprecated scope, which is the only way to express DEPLOY and READONLY. keys.create with the scope keyword keeps working as a deprecated alias, and a key with no scope equivalent lists as "-" rather than failing the whole listing. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
dazip
force-pushed
the
prod-3005-keys-policy-preset-wire
branch
from
September 21, 2026 15:05
d226fdd to
7630300
Compare
Contributor
Author
|
Superseded by #1185, which combines all three layers into a single PR so the CLI features ship in one release. The work from this PR is carried over there unchanged apart from the preset no longer being sent on the deprecated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only FULL and API can be expressed as a legacy scope, so DEPLOY and READONLY are unreachable while presets are mapped onto that field.
Presets now travel in
policy_presetwithscopeleft unset, which is what the field's mutual-exclusion rule requires, and DEPLOY and READONLY join the flag choices and the interactive picker.keys.create(scope=...)keeps working as a deprecated alias that maps to the equivalent preset. A key whose permissions have no scope equivalent now lists as-instead of raising and taking the rest offal keys listdown with it.This must not merge or ship before the server reads
policy_preset. Against a server that ignores the field, an absentscopeparses as enum 0 — ADMIN — so--preset APIwould silently mint a full-access key. Since at most one of the three fields may be set, no encoding is safe against both an old and a new server; it has to be deploy ordering.Stacked on #1178, and carries #1177 for the wire fields.