Repository navigation
Conversation
dazip
changed the title
dazip
force-pushed
the
prod-3005-keys-policy-preset-wire
branch
from
September 18, 2026 21:05
bf9a56e to
d226fdd
Compare
dazip
force-pushed
the
prod-3005-keys-custom-permissions
branch
from
September 18, 2026 21:05
536e113 to
535bbc4
Compare
Adds --permission for a key no preset covers, and a CUSTOM row in the interactive picker that prompts for the list. Permissions travel in the inline KeyPolicy; the server validates the names. The picker now prompts at the permissions level rather than "Select a preset", since its last row is CUSTOM rather than a preset. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
dazip
force-pushed
the
prod-3005-keys-policy-preset-wire
branch
from
September 21, 2026 15:05
d226fdd to
7630300
Compare
dazip
force-pushed
the
prod-3005-keys-custom-permissions
branch
from
September 21, 2026 15:05
535bbc4 to
39e6c5c
Compare
Contributor
Author
|
Superseded by #1185, which combines all three layers into a single PR so the CLI features ship in one release. The work from this PR is carried over there unchanged apart from the preset no longer being sent on the deprecated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Presets cover the common cases, but not a key that needs a permission set no preset groups together.
fal keys creategains--permission, which is repeatable and also accepts a comma separated list, and the interactive picker gains a CUSTOM row that prompts for the permissions. Either way they travel in the inlineKeyPolicyfrom #1177.The CLI does not carry its own copy of the permission catalog. There is no RPC to read one, and a local copy would drift from the server's definitions, so names are passed through and the server validates them.
Note for release:
falfloorsisolate-proto>=0.34.2, which predatespolicy_presetandKeyPolicy. That floor needs bumping to whatever version ships #1177, or key creation fails at runtime.Stacked on #1179.