Skip to content

fix(agent): sign in at the current host when the PDS cannot be discovered - #189

Merged
ewanc26 merged 1 commit into
mainfrom
fix/discover-fallback
Oct 7, 2026
Merged

ewanc26 merged 1 commit into
mainfrom
fix/discover-fallback

Conversation

@ewanc26

@ewanc26 ewanc26 commented Oct 7, 2026

Copy link
Copy Markdown
Owner

What this changes

wf_agent_login_discovered (v0.38.0) returned an error when a handle could not be resolved to a PDS, so an account that publishes no PDS record could not sign in at all. It now logs in at the agent's current host, as it did before discovery existed. *out_pds stays NULL in that case.

Found by Cobalt's end-to-end test (cobalt#202), whose mock PDS does not serve handle resolution.

Verification

test_agent_login_discovered passes on the host build (argument checks; an unresolvable .invalid handle reports no PDS). The end-to-end path is exercised by Cobalt's e2e once this is in a release.

Docs

Header comment on wf_agent_login_discovered; CHANGELOG entry.

Changelog: CHANGELOG.md

Checklist

  • CI is green (CI gate and flow / conventions)
  • No secrets, tokens or signing keys in the diff
  • Tests added or changed with the behaviour; none skipped, disabled or deleted

🤖 Generated with Claude Code

…ered

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@ewanc26
ewanc26 merged commit 56f2dde into main Oct 7, 2026
17 checks passed
@ewanc26
ewanc26 deleted the fix/discover-fallback branch October 7, 2026 22:40
@ewanc26 ewanc26 mentioned this pull request Oct 7, 2026
2 of 3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant