Repository navigation
fix(agent): sign in at the current host when the PDS cannot be discovered - #189
Merged
Merged
Conversation
…ered Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
wf_agent_login_discovered(v0.38.0) returned an error when a handle could not be resolved to a PDS, so an account that publishes no PDS record could not sign in at all. It now logs in at the agent's current host, as it did before discovery existed.*out_pdsstays NULL in that case.Found by Cobalt's end-to-end test (cobalt#202), whose mock PDS does not serve handle resolution.
Verification
test_agent_login_discoveredpasses on the host build (argument checks; an unresolvable.invalidhandle reports no PDS). The end-to-end path is exercised by Cobalt'se2eonce this is in a release.Docs
Header comment on
wf_agent_login_discovered; CHANGELOG entry.Changelog: CHANGELOG.md
Checklist
CI gateandflow / conventions)🤖 Generated with Claude Code